# finishing-a-development-branch

> Use when implementation is complete, all tests pass, and you need to decide how to integrate the work - guides completion of development work by presenting structured options for merge, PR, or cleanup

- Author: GeJiaXiang
- Repository: shellus/mysuperpower
- Version: 20260124174037
- Stars: 0
- Forks: 0
- Last Updated: 2026-02-06
- Source: https://github.com/shellus/mysuperpower
- Web: https://mule.run/skillshub/@@shellus/mysuperpower~finishing-a-development-branch:20260124174037

---

---
name: finishing-a-development-branch
description: Use when implementation is complete, all tests pass, and you need to decide how to integrate the work - guides completion of development work by presenting structured options for merge, PR, or cleanup
---

# Finishing a Development Branch

## Overview

Guide completion of development work by presenting clear options and handling chosen workflow.

**Core principle:** Verify tests → Present options → Execute choice → Clean up.

**Announce at start:** "I'm using the finishing-a-development-branch skill to complete this work."

## The Process

### Step 1: Verify Tests

**Before presenting options, verify tests pass:**

```bash
# Run project's test suite
npm test / cargo test / pytest / go test ./...
```

**If tests fail:**
```
Tests failing (<N> failures). Must fix before completing:

[Show failures]

Cannot proceed with merge/PR until tests pass.
```

Stop. Don't proceed to Step 2.

**If tests pass:** Continue to Step 2.

### Step 2: Determine Base Branch

```bash
# Try common base branches
git merge-base HEAD main 2>/dev/null || git merge-base HEAD master 2>/dev/null
```

Or ask: "This branch split from main - is that correct?"

### Step 3: Present Options

Present exactly these 4 options:

```
Implementation complete. What would you like to do?

1. Merge back to <base-branch> locally
2. Push and create a Pull Request
3. Keep the branch as-is (I'll handle it later)
4. Discard this work

Which option?
```

**Don't add explanation** - keep options concise.

### Step 4: Execute Choice

#### Option 1: Merge Locally

```bash
# Switch to base branch
git checkout <base-branch>

# Pull latest
git pull

# Merge feature branch
git merge <feature-branch>

# Verify tests on merged result
<test command>

# If tests pass
git branch -d <feature-branch>
```

Then: If in worktree, cleanup (Step 5)

#### Option 2: Push and Create PR

```bash
# Push branch
git push -u origin <feature-branch>

# Create PR
gh pr create --title "<title>" --body "$(cat <<'EOF'
## Summary
<2-3 bullets of what changed>

## Test Plan
- [ ] <verification steps>
EOF
)"
```

Then: If in worktree, cleanup (Step 5)

#### Option 3: Keep As-Is

Report: "Keeping branch <name>."

If in worktree, add: "Worktree preserved at <path>."

**Don't cleanup worktree.**

#### Option 4: Discard

**Confirm first (adjust message based on whether in worktree):**

If in worktree:
```
This will permanently delete:
- Branch <name>
- All commits: <commit-list>
- Worktree at <path>

Type 'discard' to confirm.
```

If not in worktree:
```
This will permanently delete:
- Branch <name>
- All commits: <commit-list>

Type 'discard' to confirm.
```

Wait for exact confirmation.

If confirmed:
```bash
git checkout <base-branch>
git branch -D <feature-branch>
```

Then: If in worktree, cleanup (Step 5)

### Step 5: Cleanup Worktree (Conditional)

**First, detect if working in a worktree:**

```bash
# Check if current directory is a worktree (not the main working tree)
git rev-parse --is-inside-work-tree > /dev/null 2>&1 && \
  [ "$(git rev-parse --git-dir)" != ".git" ]
```

Or check worktree list:
```bash
git worktree list | wc -l
# If > 1, worktrees exist; check if current path matches a worktree
```

**If NOT in worktree:** Skip this step entirely. No cleanup needed.

**If in worktree, for Options 1, 2, 4:**

```bash
git worktree remove <worktree-path>
```

**For Option 3:** Keep worktree.

## Quick Reference

| Option | Merge | Push | Cleanup Branch | Cleanup Worktree (if any) |
|--------|-------|------|----------------|---------------------------|
| 1. Merge locally | ✓ | - | ✓ | ✓ |
| 2. Create PR | - | ✓ | - | ✓ |
| 3. Keep as-is | - | - | - | - |
| 4. Discard | - | - | ✓ (force) | ✓ |

## Common Mistakes

**Skipping test verification**
- **Problem:** Merge broken code, create failing PR
- **Fix:** Always verify tests before offering options

**Open-ended questions**
- **Problem:** "What should I do next?" → ambiguous
- **Fix:** Present exactly 4 structured options

**Assuming worktree exists**
- **Problem:** Worktree cleanup commands fail when not using worktrees
- **Fix:** Always detect if in worktree first; skip cleanup if not

**No confirmation for discard**
- **Problem:** Accidentally delete work
- **Fix:** Require typed "discard" confirmation

## Red Flags

**Never:**
- Proceed with failing tests
- Merge without verifying tests on result
- Delete work without confirmation
- Force-push without explicit request
- Assume worktree usage without checking

**Always:**
- Verify tests before offering options
- Present exactly 4 options
- Get typed confirmation for Option 4
- Detect worktree before attempting cleanup

## Integration

**Called by:**
- **subagent-driven-development** (Step 7) - After all tasks complete
- **executing-plans** (Step 5) - After all batches complete

**Pairs with:**
- **using-git-worktrees** - If used, cleans up worktree created by that skill

**Note:** This skill works with or without git worktrees. Worktree detection is automatic.