--- name: flow-next-impl-review description: John Carmack-level implementation review via RepoPrompt or Codex. Use when reviewing code changes, PRs, or implementations. Triggers on \/flow-next:impl-review. --- # Implementation Review Mode **Read [workflow.md](workflow.md) for detailed phases and anti-patterns.** Conduct a John Carmack-level review of implementation changes on the current branch. **Role**: Code Review Coordinator (NOT the reviewer) **Backends**: RepoPrompt (rp), RepoPrompt MCP (mcp), or Codex CLI (codex) **⚠️ RepoPrompt 1.6.0+ Required**: The RP backend now uses builder review mode which requires RepoPrompt 1.6.0 or later. Check version: `rp-cli --version` **CRITICAL: flowctl is BUNDLED — NOT installed globally.** `which flowctl` will fail (expected). Always use: ```bash FLOWCTL="${CLAUDE_PLUGIN_ROOT}\/scripts\/flowctl" ``` ## Backend Selection **Priority** (first match wins): 1. `--review=rp|codex|mcp|export|none` argument 2. `FLOW_REVIEW_BACKEND` env var (`rp`, `codex`, `mcp`, `none`) 3. `.flow\/config.json` → `review.backend` 4. **Error** - no auto-detection ### Parse from arguments first Check $ARGUMENTS for: - `--review=rp` or `--review rp` → use rp - `--review=codex` or `--review codex` → use codex - `--review=mcp` or `--review mcp` → use mcp - `--review=export` or `--review export` → use export - `--review=none` or `--review none` → skip review If found, use that backend and skip all other detection. ### Otherwise read from config ```bash BACKEND=$($FLOWCTL review-backend) if [[ "$BACKEND" == "ASK" ]]; then echo "Error: No review backend configured." echo "Run \/flow-next:setup to configure, or pass --review=rp|codex|mcp|none" exit 1 fi echo "Review backend: $BACKEND (override: --review=rp|codex|mcp|none)" ``` ## Critical Rules **For rp backend:** 1. **DO NOT REVIEW CODE YOURSELF** - you coordinate, RepoPrompt reviews 2. **MUST WAIT for actual RP response** - never simulate\/skip the review 3. **MUST use `setup-review`** - handles window selection + builder atomically 4. **DO NOT add --json flag to chat-send** - it suppresses the review response 5. **Re-reviews MUST stay in SAME chat** - omit `--new-chat` after first review **For codex backend:** 1. Use `$FLOWCTL codex impl-review` exclusively 2. Pass `--receipt` for session continuity on re-reviews 3. Parse verdict from command output **For mcp backend:** 1. **DO NOT REVIEW CODE YOURSELF** - you coordinate, RepoPrompt reviews 2. **MUST WAIT for actual MCP response** - never simulate\/skip the review 3. **Use MCP tools directly** - do NOT call `flowctl rp *` commands 4. **Re-reviews MUST stay in SAME chat** - pass same chat_id, new_chat: false 5. See [workflow.md](workflow.md) Phase: MCP Backend Workflow **For all backends:** - If `REVIEW_RECEIPT_PATH` set: write receipt after review (any verdict) - Any failure → output `RETRY<\/promise>` and stop **FORBIDDEN**: - Self-declaring SHIP without actual backend verdict - Mixing backends mid-review (stick to one) - Skipping review when backend is "none" without user consent ## Input Arguments: $ARGUMENTS Format: `[task ID] [--base ] [focus areas]` - `--base ` - Compare against this commit instead of main\/master (for task-scoped reviews) - Task ID - Optional, for context and receipt tracking - Focus areas - Optional, specific areas to examine **Scope behavior:** - With `--base`: Reviews only changes since that commit (task-scoped) - Without `--base`: Reviews entire branch vs main\/master (full branch review) ## Workflow **See [workflow.md](workflow.md) for full details on each backend.** ```bash FLOWCTL="${CLAUDE_PLUGIN_ROOT}\/scripts\/flowctl" REPO_ROOT="$(git rev-parse --show-toplevel 2>\/dev\/null || pwd)" ``` ### Step 0: Parse Arguments Parse $ARGUMENTS for: - `--base ` → `BASE_COMMIT` (if provided, use for scoped diff) - First positional arg matching `fn-*` → `TASK_ID` - Remaining args → focus areas If `--base` not provided, `BASE_COMMIT` stays empty (will fall back to main\/master). ### Step 1: Detect Backend Run backend detection from SKILL.md above. Then branch: ### Codex Backend ```bash RECEIPT_PATH="${REVIEW_RECEIPT_PATH:-\/tmp\/impl-review-receipt.json}" # Use BASE_COMMIT if provided, else fall back to main if [[ -n "$BASE_COMMIT" ]]; then $FLOWCTL codex impl-review "$TASK_ID" --base "$BASE_COMMIT" --receipt "$RECEIPT_PATH" else $FLOWCTL codex impl-review "$TASK_ID" --base main --receipt "$RECEIPT_PATH" fi # Output includes VERDICT=SHIP|NEEDS_WORK|MAJOR_RETHINK ``` On NEEDS_WORK: fix code, commit, re-run (receipt enables session continuity). ### RepoPrompt Backend ```bash # Step 1: Identify changes (use BASE_COMMIT if provided, else main\/master) git branch --show-current if [[ -n "$BASE_COMMIT" ]]; then DIFF_BASE="$BASE_COMMIT" else DIFF_BASE="main" git rev-parse main >\/dev\/null 2>&1 || DIFF_BASE="master" fi git log ${DIFF_BASE}..HEAD --oneline git diff ${DIFF_BASE}..HEAD --name-only # Step 2: Atomic setup eval "$($FLOWCTL rp setup-review --repo-root "$REPO_ROOT" --summary "Review implementation:

")" # Outputs W= T=. If fails → RETRY<\/promise> # Step 3: Augment selection (add changed files) $FLOWCTL rp select-add --window "$W" --tab "$T" path\/to\/changed\/files... # Step 4: Build and send review prompt (see workflow.md) $FLOWCTL rp chat-send --window "$W" --tab "$T" --message-file \/tmp\/review-prompt.md --new-chat --chat-name "Impl Review: [BRANCH]" # Step 5: Write receipt if REVIEW_RECEIPT_PATH set ``` ## Fix Loop (INTERNAL - do not exit to Ralph) **CRITICAL: Do NOT ask user for confirmation. Automatically fix ALL valid issues and re-review — our goal is production-grade world-class software and architecture. Never use AskUserQuestion in this loop.** If verdict is NEEDS_WORK, loop internally until SHIP: 1. **Parse issues** from reviewer feedback (Critical → Major → Minor) 2. **Fix code** and run tests\/lints 3. **Commit fixes** (mandatory before re-review) 4. **Re-review**: - **Codex**: Re-run `flowctl codex impl-review` (receipt enables context) - **RP**: `$FLOWCTL rp chat-send --window "$W" --tab "$T" --message-file \/tmp\/re-review.md` (NO `--new-chat`) 5. **Repeat** until `SHIP<\/verdict>` **CRITICAL**: For RP, re-reviews must stay in the SAME chat so reviewer has context. Only use `--new-chat` on the FIRST review.